Fix Unicode encoding failure in directory export when creating filenames from journal titles with certain characters #1090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1089.
It turns out that
strftime
doesn't play nicely with all Unicode characters. I think this is a Windows-specific issue, but I'm not sure, and we're testing on all platforms anyway. This PR modifies the directory export's file name builder to usestrftime
to handle only the date part of the filename, then append the rest of the string, which may contain just about any character.Checklist
for the same issue.